mhenc commented on code in PR #34042:
URL: https://github.com/apache/airflow/pull/34042#discussion_r1315654697
##########
airflow/serialization/pydantic/dag_run.py:
##########
@@ -26,7 +26,7 @@
class DagRunPydantic(BaseModelPydantic):
"""Serializable representation of the DagRun ORM SqlAlchemyModel used by
internal API."""
- id: int
+ id: Optional[int]
Review Comment:
Fair point :)
We may need it for TriggerDag Operator - but this is outside of this PR.
So currently it's only for tests (but I can fix them) and also for
consitency - some *Pydantic objects will have id as Optional (e.g. Job
https://github.com/apache/airflow/pull/34026) so we may keep it Optional there
for consistency
But if you belive it's better to leave it as "int" then I can revert this
change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
