mhenc commented on code in PR #34042:
URL: https://github.com/apache/airflow/pull/34042#discussion_r1317138688


##########
airflow/serialization/pydantic/dag_run.py:
##########
@@ -26,7 +26,7 @@
 class DagRunPydantic(BaseModelPydantic):
     """Serializable representation of the DagRun ORM SqlAlchemyModel used by 
internal API."""
 
-    id: int
+    id: Optional[int]

Review Comment:
   Actually Job must have it as in 
   https://github.com/apache/airflow/pull/34026
   we call "add_job" which is actual the case where Id is empty.
   
   Removing it from DagRunPydantic.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to