potiuk commented on code in PR #35867:
URL: https://github.com/apache/airflow/pull/35867#discussion_r1408582321
##########
airflow/serialization/serde.py:
##########
@@ -83,6 +91,81 @@ def decode(d: dict[str, Any]) -> tuple[str, int, Any]:
return classname, version, data
+def encrypt(value: P) -> str:
Review Comment:
I am not sure if i understand what's going on. To be honest now that I look
at this code, i have several doubts about the approach. I am not sur for
example why we have iceberg and deltalake in "airflow" and not providers? Not
sure what's the reasoning there. Why do we actually need to implement somewhat
complex way of encryption.
I am not saying I am against this, but I have hard time commenting it
without understanding the context. Maybe we could indeed start the discussion
we talked about about general use case for serde, why it is useful, where we
want to use it etc. That would likely help to put it in context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
