potiuk commented on code in PR #35867:
URL: https://github.com/apache/airflow/pull/35867#discussion_r1414219414
##########
airflow/serialization/serde.py:
##########
@@ -83,6 +91,81 @@ def decode(d: dict[str, Any]) -> tuple[str, int, Any]:
return classname, version, data
+def encrypt(value: P) -> str:
Review Comment:
I see the explanation now from the discussion in devlist.
Following on that - should not the decrypt/encrypt be a generic utility in
this case rather than part of serde? I see these two methods as part of general
functionality exposed to any kind of utilities - not only serde?
What got me confused was that encrypt/decrypt was part of serde, which what
made me think this is something only for serde but I see it now as
"encrypt/decrypt" util used by particular, dedicated serializers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
