potiuk commented on code in PR #35867:
URL: https://github.com/apache/airflow/pull/35867#discussion_r1408905802
##########
airflow/serialization/serde.py:
##########
@@ -83,6 +91,81 @@ def decode(d: dict[str, Any]) -> tuple[str, int, Any]:
return classname, version, data
+def encrypt(value: P) -> str:
Review Comment:
And yes - I do not know too much about serde. I have not been paying too
much attention to it so far - but when I am asked to review it, my natural
instict is try to understand what we are doing and why - and when I started
looking more closely - and I see things like iceberg being part of the "core"
of airflow where we have "providers" dedicated for years to keep things
dedicated to integration of airflow, and serializing primitives (which seems
quite wrong from the security properties point of view) my natural instict is
to try to understand why we are doing it all this way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
