bolkedebruin commented on code in PR #35867:
URL: https://github.com/apache/airflow/pull/35867#discussion_r1409037733
##########
airflow/serialization/serde.py:
##########
@@ -83,6 +91,81 @@ def decode(d: dict[str, Any]) -> tuple[str, int, Any]:
return classname, version, data
+def encrypt(value: P) -> str:
Review Comment:
I'll reach out separately on the understanding part.
For this PR:
No, there is no introduction of a separate encryption. It works with fernet
exactly as the other places in airflow. It uses a protocol to store the type
information because using fernet encryption that is lost or cannot be done (ie.
Direct encryption of an int results in a tyoeerror).
It is done selectively because you might want to see e.g. the "conn_id" in
the ui if you need to debug. Just like how we encrypt sensitive information of
connections but not all information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
