eladkal commented on code in PR #36789:
URL: https://github.com/apache/airflow/pull/36789#discussion_r1460384607
##########
airflow/providers/google/cloud/operators/vertex_ai/custom_job.py:
##########
@@ -445,9 +445,19 @@ def __init__(
self,
*,
command: Sequence[str] = [],
+ region: str,
+ parent_model: str | None = None,
+ impersonation_chain: str | Sequence[str] | None = None,
+ dataset_id: str | None = None,
Review Comment:
Right now we don't have any protection so I think our priority should be to
introduce the pre-commit.
I do agree that there is room for improvement but the question is if it's
must be now or we can do it later.
I know @sharar1 had some problems with that specific issue thus he decided
to consider it out of scope for this phase.
@Taragolis since you are not OK with this approach the only suggestion I can
think of is to exclude the relevant operators from the pre-commit till the next
phase of improvements for the pre-commit.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
