potiuk commented on code in PR #36789:
URL: https://github.com/apache/airflow/pull/36789#discussion_r1468059293
##########
airflow/providers/google/cloud/operators/vertex_ai/custom_job.py:
##########
@@ -445,9 +445,19 @@ def __init__(
self,
*,
command: Sequence[str] = [],
+ region: str,
+ parent_model: str | None = None,
+ impersonation_chain: str | Sequence[str] | None = None,
+ dataset_id: str | None = None,
Review Comment:
Yeah, while this is not perfect from the duplication point of view, I agree
with @eladkal that likely in this case having a "imperfect" enforcement done by
pre-commit to prevent some common mistakes elsewhere is a good idea.
Another option is to figure out another way of allowing for such exception.
Typicaly we have all the `#noqa` , `# type : ignore` and other similar
comments that disable such checks from ruff and others, so maybe we should have
something similar here - and in this case mark explicitly this class as "safe
to ignore the rule" by adding an explicit comment that will cause the
pre-commit to skip the class when checking it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
