Taragolis commented on code in PR #36789:
URL: https://github.com/apache/airflow/pull/36789#discussion_r1477259108
##########
airflow/providers/google/cloud/operators/vertex_ai/custom_job.py:
##########
@@ -445,9 +445,19 @@ def __init__(
self,
*,
command: Sequence[str] = [],
+ region: str,
+ parent_model: str | None = None,
+ impersonation_chain: str | Sequence[str] | None = None,
+ dataset_id: str | None = None,
Review Comment:
I guess original issue comes from the
https://github.com/apache/airflow/blob/8961bab6b2ed387bea1193fb3199a1c56ba4455c/scripts/ci/pre_commit/pre_commit_validate_operators_init.py#L176
So I would suggest to create the issue for this TODO, otherwise I guess
there is a risk that we forget about it and after couple year we can't figure
out what this comment about.
And for now apply this solution even if it not perfect, until we could check
fields through MRO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
