eladkal commented on code in PR #36789:
URL: https://github.com/apache/airflow/pull/36789#discussion_r1460391899


##########
airflow/providers/google/cloud/operators/vertex_ai/custom_job.py:
##########
@@ -445,9 +445,19 @@ def __init__(
         self,
         *,
         command: Sequence[str] = [],
+        region: str,
+        parent_model: str | None = None,
+        impersonation_chain: str | Sequence[str] | None = None,
+        dataset_id: str | None = None,

Review Comment:
   I guess we will continue with the exclusion list:
   https://github.com/apache/airflow/pull/33786#issuecomment-1902071627
   
   It should please everyone :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to