shrukul commented on code in PR #38432:
URL: https://github.com/apache/airflow/pull/38432#discussion_r1539796806


##########
airflow/models/taskinstance.py:
##########
@@ -2455,7 +2456,7 @@ def _run_raw_task(
 
             try:
                 if not mark_success:
-                    self._execute_task_with_callbacks(context, test_mode, 
session=session)
+                    result = self._execute_task_with_callbacks(context, 
test_mode, session=session)

Review Comment:
   1. It seems that not all operators return a `result` on execution (example: 
[DatabricksSubmitRunOperator](https://github.com/apache/airflow/blob/main/airflow/providers/databricks/operators/databricks.py#L563-L564))
   2. Some operators do return a `result` - like 
([GlueOperator](https://github.com/apache/airflow/blob/main/airflow/providers/amazon/aws/operators/glue.py#L217),
 
[EmrServerlessStartJobOperator](https://github.com/apache/airflow/blob/main/airflow/providers/amazon/aws/operators/emr.py#L1472)),
 but the return value is `job_id` in these scenarios.
   
   Questions -
   1. If any of the above operators publish an Airflow dataset, how to specify 
`extra` dictionary in the corresponding dataset?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to