jscheffl commented on code in PR #38432:
URL: https://github.com/apache/airflow/pull/38432#discussion_r1542107183
##########
airflow/models/taskinstance.py:
##########
@@ -2553,21 +2554,30 @@ def _run_raw_task(
return None
- def _register_dataset_changes(self, *, session: Session) -> None:
+ def _register_dataset_changes(self, result: Any, *, session: Session) ->
None:
if TYPE_CHECKING:
assert self.task
for obj in self.task.outlets or []:
self.log.debug("outlet obj %s", obj)
# Lineage can have other types of objects besides datasets
if isinstance(obj, Dataset):
+ if obj.extra:
Review Comment:
No we should not :-(
I (previously) interpreted the `extra`field as being dynamic data. But as it
is (actually) intended to be meta data for the dataset itself I mis-interpreted
this as an option to pass extra data for this "reference" to a Dataset
(interpreted by the URI).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
