jscheffl commented on code in PR #38432:
URL: https://github.com/apache/airflow/pull/38432#discussion_r1542109168
##########
airflow/models/taskinstance.py:
##########
@@ -2455,7 +2456,7 @@ def _run_raw_task(
try:
if not mark_success:
- self._execute_task_with_callbacks(context, test_mode,
session=session)
+ result = self._execute_task_with_callbacks(context,
test_mode, session=session)
Review Comment:
Regarding 1+2: Yes, if no result is generated, the content will be just
`None`. If it is a scalar like a job_id it is rather a string. So in such cases
the output is not usable for passing along to the dataset event.
Regarding your question 1: The publish of the event actually is happening
_after_ this line of code. The change was attemping to capture the result to
put is as extra a few lines of code later from here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
