jscheffl commented on code in PR #38432:
URL: https://github.com/apache/airflow/pull/38432#discussion_r1542106481
##########
airflow/models/taskinstance.py:
##########
@@ -2553,21 +2554,30 @@ def _run_raw_task(
return None
- def _register_dataset_changes(self, *, session: Session) -> None:
+ def _register_dataset_changes(self, result: Any, *, session: Session) ->
None:
if TYPE_CHECKING:
assert self.task
for obj in self.task.outlets or []:
self.log.debug("outlet obj %s", obj)
# Lineage can have other types of objects besides datasets
if isinstance(obj, Dataset):
+ if obj.extra:
+ extra = obj.extra
Review Comment:
Sorry, then it seems I mis-understood your comments in the previous
PR7discussions about this. Thanks for clearly documenting the differences
between `Dataset` and `DatasetEvent`(both) `extra` details in #38481. This
opened my eyes and now I understand your push-back.
Now it is "clear" to me. Intent was _not_ to overwrite or mangle "static"
information for events.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
