uranusjr commented on code in PR #39185:
URL: https://github.com/apache/airflow/pull/39185#discussion_r1575634883


##########
airflow/serialization/enums.py:
##########
@@ -44,6 +44,7 @@ class DagAttributeTypes(str, Enum):
     TIMEDELTA = "timedelta"
     TIMEZONE = "timezone"
     RELATIVEDELTA = "relativedelta"
+    BASE_TRIGGER = "base_trigger"

Review Comment:
   Ah OK. Do we need to be able to serialise `Trigger` too? (The naming is a 
bit confusing too fwiw, we use Foo and FooModel in most places instead, but 
this is not the time to change it.)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to