uranusjr commented on code in PR #39185:
URL: https://github.com/apache/airflow/pull/39185#discussion_r1575666282


##########
airflow/serialization/enums.py:
##########
@@ -44,6 +44,7 @@ class DagAttributeTypes(str, Enum):
     TIMEDELTA = "timedelta"
     TIMEZONE = "timezone"
     RELATIVEDELTA = "relativedelta"
+    BASE_TRIGGER = "base_trigger"

Review Comment:
   We can call it `trigger_model` like `dag_model`.
   
   Thinking a bit, calling this `base_trigger` for now is probably not a bad 
idea as long as we don’t call the ORM class `trigger` (we can use 
`trigger_model` instead).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to