uranusjr commented on code in PR #39185:
URL: https://github.com/apache/airflow/pull/39185#discussion_r1575659970
##########
airflow/serialization/enums.py:
##########
@@ -44,6 +44,7 @@ class DagAttributeTypes(str, Enum):
TIMEDELTA = "timedelta"
TIMEZONE = "timezone"
RELATIVEDELTA = "relativedelta"
+ BASE_TRIGGER = "base_trigger"
Review Comment:
The thing is, I feel we should call this `TRIGGER` regardless of the class
name since we don’t need to have a type for the ORM class (at least I don’t
think so? Do we?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
