dstandish commented on code in PR #39185:
URL: https://github.com/apache/airflow/pull/39185#discussion_r1575664046
##########
airflow/serialization/enums.py:
##########
@@ -44,6 +44,7 @@ class DagAttributeTypes(str, Enum):
TIMEDELTA = "timedelta"
TIMEZONE = "timezone"
RELATIVEDELTA = "relativedelta"
+ BASE_TRIGGER = "base_trigger"
Review Comment:
Well... i put this to you. Suppose we _did_ need a type for the ORM. what
would be your call in that case?
I think it's best to just assume we do need it and name given that
assumption, even though not currently true.
Then if we ever do need it we won't have an issue.
I don't veto calling it the non-orm one `trigger`. We could call it
`trigger_non_orm`. Or we could just plan to call the orm one `trigger_orm`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
