pankajkoti commented on code in PR #39365:
URL: https://github.com/apache/airflow/pull/39365#discussion_r1587971097
##########
tests/system/providers/pinecone/example_pinecone_openai.py:
##########
@@ -75,15 +74,15 @@
start_date=datetime(2023, 1, 1),
catchup=False,
) as dag:
-
- @setup
- @task
- def create_index():
- from airflow.providers.pinecone.hooks.pinecone import PineconeHook
-
- hook = PineconeHook()
- hook.create_index(index_name=index_name, dimension=1536)
Review Comment:
Since it's a major release 2.0.0, having breaking changes should be fine. We
should ensure that when initialising hooks and operators if only required
params are given by users in their DAG, the initialisation & execution runs
successfully i.e. we should have a clear separation of required positional and
keywords args, and ensure keyword args have default values if needed for the
hook and operator interfaces that are needed when the user has not given those
in their DAG.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
