pankajkoti commented on code in PR #39365:
URL: https://github.com/apache/airflow/pull/39365#discussion_r1587661874
##########
tests/system/providers/pinecone/example_pinecone_openai.py:
##########
@@ -75,15 +74,15 @@
start_date=datetime(2023, 1, 1),
catchup=False,
) as dag:
-
- @setup
- @task
- def create_index():
- from airflow.providers.pinecone.hooks.pinecone import PineconeHook
-
- hook = PineconeHook()
- hook.create_index(index_name=index_name, dimension=1536)
Review Comment:
@rawwar I guess you meant to tag me, my github ID is @pankajkoti :)
Yes, that was exactly my question. We should demonstrate here then how to
pass the needed spec argument.
Additionally, we should also check that the operator is able to pass the
spec argument as is required to the hook method in its execution. For that we
will need to recheck the arguments for the operator initialisation and ensure
the signature and interfaces are working.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
