utkarsharma2 commented on code in PR #39365:
URL: https://github.com/apache/airflow/pull/39365#discussion_r1587678297
##########
tests/system/providers/pinecone/example_pinecone_openai.py:
##########
@@ -75,15 +74,15 @@
start_date=datetime(2023, 1, 1),
catchup=False,
) as dag:
-
- @setup
- @task
- def create_index():
- from airflow.providers.pinecone.hooks.pinecone import PineconeHook
-
- hook = PineconeHook()
- hook.create_index(index_name=index_name, dimension=1536)
Review Comment:
@rawwar I think we should just expose the `PodSpec` to be created by user or
we can also use `pod_spec_kwargs: dict` in `CreatePodIndexOperator` and pass it
to `PodSpec` object. It saves us the maintenance overhead. Since for example
if there is a parameter deprecation or addition to `PodSpec` we need to keep up
with the interface.
But I'm afraid we might be little late to make change in the interface now.
Since this should have been done in initial
[PR](https://github.com/apache/airflow/pull/37307) or next major release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
