sunank200 commented on code in PR #39365:
URL: https://github.com/apache/airflow/pull/39365#discussion_r1587686655
##########
tests/system/providers/pinecone/example_pinecone_openai.py:
##########
@@ -75,15 +74,15 @@
start_date=datetime(2023, 1, 1),
catchup=False,
) as dag:
-
- @setup
- @task
- def create_index():
- from airflow.providers.pinecone.hooks.pinecone import PineconeHook
-
- hook = PineconeHook()
- hook.create_index(index_name=index_name, dimension=1536)
Review Comment:
It's a breaking change as mentioned in this
https://github.com/apache/airflow/pull/37307. This is missing specs as per
`hook. def create_index(
self,
index_name: str,
dimension: int,
spec: ServerlessSpec | PodSpec,
metric: str | None = None,
timeout: int | None = None,
)` arguments have changed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]