rzjfr commented on PR #40554: URL: https://github.com/apache/airflow/pull/40554#issuecomment-2206605668
> Could you add a test that fails without your fix? Hi @hussein-awala, Thank you for reviewing the PR, It's bit tricky to write a test to catch the key duplication as `render_chart` returns a dictionary. But since the in the order of annotations, `.Values.airflowPodAnnotations` comes after for example `.Values.dagProcessor.safeToEvict` ([here](https://github.com/apache/airflow/blob/7426af21438e32d931ea2193a291100743a931fe/chart/templates/dag-processor/dag-processor-deployment.yaml#L79C16-L84)) then the last one which is worker's `safeToEvict` value overwrites service's own `safeToEvict` . So that was the only valid test which comes to my mind. I just added that, Please let me know if you had a better proposal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
