rzjfr commented on PR #40554: URL: https://github.com/apache/airflow/pull/40554#issuecomment-2209458419
I realized probably I should add bit of an expatiation on the solution as well. `merge` or `mergeOverwrite` actually combine the given parameters from right to left into the left most parameter. So what is actually happening is that [pod-template](https://github.com/apache/airflow/blob/fa447c25054f6b23e228e40fe24e5091bf8bbbb9/chart/files/pod-template-file.kubernetes-helm-yaml#L29) is changing `.Values.airflowPodAnnotations` and since `.Values.airflowPodAnnotations` is being used in other services like scheduler, triggerer and dag-processor it causes issue. Since `.Values.airflowPodAnnotations` is being added separately after services' own `safeToEvict` annotation the result would have the safe to evict annotation at least twice. Actually from the two the one that matters most (the second one) is going to be the incorrect one (only if for example `.Values.triggerer.podAnnotations` is not set) as `.Values.airflowPodAnnotations` evaluated after services' own safe to evict annotation and `.Values.airflowPodAnnotations` would have workers' safe to evict value beca use `pod-template` has set it. For example [here](https://helm-playground.com/#t=IYLgBA3hYHQGrADYFcCmBnGwwF8cCgAjcKWBFDGQ3AgYxOniTU1pv3wFtUAnAc1QMw3fqgDyAN14B3HgEsALqjLNK2JhUzUNLGGzwdQkRuV3YDxYys1V29Kzsr6CQA&v=LQhQCIENwLgAlHOVbOhARrRyv3FhAMbZLgn4mhA) you can see value of `a` (the left most variable) in the output. in `pod-template` if we add a copy of `Values.airflowPodAnnotations` instead, the issue would be resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
