jedcunningham commented on code in PR #40554:
URL: https://github.com/apache/airflow/pull/40554#discussion_r1669400500
##########
helm_tests/airflow_aux/test_pod_template_file.py:
##########
@@ -660,6 +660,26 @@ def test_safe_to_evict_annotation(self, safe_to_evict:
bool):
"cluster-autoscaler.kubernetes.io/safe-to-evict": "true" if
safe_to_evict else "false"
}
+ def test_safe_to_evict_annotation_other_services(self):
+ docs = render_chart(
+ values={
+ "workers": {"safeToEvict": False},
+ "scheduler": {"safeToEvict": True},
Review Comment:
Can you add a comment on why you are setting config for
scheduler/triggerer/etc, and checking those deployments too, in the pod
template file tests?
Or, maybe just remove those and leave it worker/pod template? That might be
better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
