rzjfr commented on code in PR #40554:
URL: https://github.com/apache/airflow/pull/40554#discussion_r1670735464
##########
helm_tests/airflow_aux/test_pod_template_file.py:
##########
@@ -660,6 +660,26 @@ def test_safe_to_evict_annotation(self, safe_to_evict:
bool):
"cluster-autoscaler.kubernetes.io/safe-to-evict": "true" if
safe_to_evict else "false"
}
+ def test_safe_to_evict_annotation_other_services(self):
+ docs = render_chart(
+ values={
+ "workers": {"safeToEvict": False},
+ "scheduler": {"safeToEvict": True},
Review Comment:
Sorry for my previous message, Probably I should have put it like this, one
consequence of this issue is that if you apply the rendered manifest of the
chart in kubernetes, workers' safeToEvict always overwrites safeToEvict of
other services. This test covers that.
I just added a docstring to the test function hoping it would be both short
and descriptive, please let me know if there were a need for any adjustments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
