shahar1 commented on code in PR #41887:
URL: https://github.com/apache/airflow/pull/41887#discussion_r1767587831
##########
airflow/providers/google/cloud/hooks/dataflow.py:
##########
@@ -1124,18 +1124,17 @@ def build_dataflow_job_name(job_name: str,
append_job_name: bool = True) -> str:
return safe_job_name
- @_fallback_to_location_from_variables
@_fallback_to_project_id_from_variables
@GoogleBaseHook.fallback_to_default_project_id
def is_job_dataflow_running(
self,
name: str,
project_id: str,
- location: str = DEFAULT_DATAFLOW_LOCATION,
+ location: str,
Review Comment:
This is a breaking change.
In the case of version differences between beam and dataflow providers
(dataflow newer than beam), this parameter could be provided as `None` - and
then an error will be raised.
Personally I don't think that it's harmful to retain the default location,
considering the fact that it will be set by the latest beam provider. If we
deprecate it, then we should do it more carefully.
Please let me know what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
