shahar1 commented on code in PR #41887:
URL: https://github.com/apache/airflow/pull/41887#discussion_r1768866114
##########
airflow/providers/google/cloud/hooks/dataflow.py:
##########
@@ -1124,18 +1124,17 @@ def build_dataflow_job_name(job_name: str,
append_job_name: bool = True) -> str:
return safe_job_name
- @_fallback_to_location_from_variables
@_fallback_to_project_id_from_variables
@GoogleBaseHook.fallback_to_default_project_id
def is_job_dataflow_running(
self,
name: str,
project_id: str,
- location: str = DEFAULT_DATAFLOW_LOCATION,
+ location: str,
Review Comment:
I understand and agree with your statement - we could deprecate it (now or
in another PR), but it should done with some cautious. Something like:
1. Setting the default value to None, rather than `us-central1`.
2. If it's None - use the current `us-central1` value with a deprecation
warning that it becomes a mandatory parameter. Otherwise, use the current value.
After it gets released, we could make it mandatory and remove the default
`None` value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
