lukas-mi commented on code in PR #41887:
URL: https://github.com/apache/airflow/pull/41887#discussion_r1768677986
##########
airflow/providers/google/cloud/hooks/dataflow.py:
##########
@@ -1124,18 +1124,17 @@ def build_dataflow_job_name(job_name: str,
append_job_name: bool = True) -> str:
return safe_job_name
- @_fallback_to_location_from_variables
@_fallback_to_project_id_from_variables
@GoogleBaseHook.fallback_to_default_project_id
def is_job_dataflow_running(
self,
name: str,
project_id: str,
- location: str = DEFAULT_DATAFLOW_LOCATION,
+ location: str,
Review Comment:
I see your point regarding version difference and the potential for
resulting incompatibility. I can change back to having the default location if
it results in least friction.
It just from my experience using defaults for configuration parameters that
should always be provided anyway doesn't lead to anything good. I suppose that
wasn't "really" a problem in this case as it seems that no one attempted to use
beam/dataflow providers outside US or at least cared to make an issue on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
