lukas-mi commented on code in PR #41887:
URL: https://github.com/apache/airflow/pull/41887#discussion_r1771128134
##########
airflow/providers/google/cloud/hooks/dataflow.py:
##########
@@ -1124,18 +1124,17 @@ def build_dataflow_job_name(job_name: str,
append_job_name: bool = True) -> str:
return safe_job_name
- @_fallback_to_location_from_variables
@_fallback_to_project_id_from_variables
@GoogleBaseHook.fallback_to_default_project_id
def is_job_dataflow_running(
self,
name: str,
project_id: str,
- location: str = DEFAULT_DATAFLOW_LOCATION,
+ location: str,
Review Comment:
I've add the deprecation warning as suggested. There is this build step that
I can't seem to please
(https://github.com/apache/airflow/actions/runs/10991332247/job/30513696655?pr=41887),
maybe you could help with what it's complaining about?
##########
airflow/providers/google/cloud/hooks/dataflow.py:
##########
@@ -1124,18 +1124,17 @@ def build_dataflow_job_name(job_name: str,
append_job_name: bool = True) -> str:
return safe_job_name
- @_fallback_to_location_from_variables
@_fallback_to_project_id_from_variables
@GoogleBaseHook.fallback_to_default_project_id
def is_job_dataflow_running(
self,
name: str,
project_id: str,
- location: str = DEFAULT_DATAFLOW_LOCATION,
+ location: str,
Review Comment:
I've added the deprecation warning as suggested. There is this build step
that I can't seem to please
(https://github.com/apache/airflow/actions/runs/10991332247/job/30513696655?pr=41887),
maybe you could help with what it's complaining about?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
