ephraimbuddy commented on code in PR #44755:
URL: https://github.com/apache/airflow/pull/44755#discussion_r1875493249
##########
airflow/utils/db.py:
##########
@@ -950,8 +950,12 @@ def synchronize_log_template(*, session: Session =
NEW_SESSION) -> None:
log.info("Log template table does not exist (added in 2.3.0); skipping
log template sync.")
return
+ es_log_it_template_fallback =
"{dag_id}-{task_id}-{execution_date}-{try_number}"
+
filename = conf.get("logging", "log_filename_template")
- elasticsearch_id = conf.get("elasticsearch", "log_id_template")
+ elasticsearch_id = conf.get("elasticsearch", "log_id_template",
fallback=es_log_it_template_fallback)
Review Comment:
```suggestion
elasticsearch_id = conf.get("elasticsearch", "log_id_template",
fallback=es_log_id_template_fallback)
```
##########
airflow/utils/db.py:
##########
@@ -950,8 +950,12 @@ def synchronize_log_template(*, session: Session =
NEW_SESSION) -> None:
log.info("Log template table does not exist (added in 2.3.0); skipping
log template sync.")
return
+ es_log_it_template_fallback =
"{dag_id}-{task_id}-{execution_date}-{try_number}"
Review Comment:
```suggestion
es_log_id_template_fallback =
"{dag_id}-{task_id}-{execution_date}-{try_number}"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
