potiuk commented on code in PR #44755:
URL: https://github.com/apache/airflow/pull/44755#discussion_r1875589278
##########
airflow/utils/db.py:
##########
@@ -950,8 +950,12 @@ def synchronize_log_template(*, session: Session =
NEW_SESSION) -> None:
log.info("Log template table does not exist (added in 2.3.0); skipping
log template sync.")
return
+ es_log_it_template_fallback =
"{dag_id}-{task_id}-{execution_date}-{try_number}"
+
filename = conf.get("logging", "log_filename_template")
- elasticsearch_id = conf.get("elasticsearch", "log_id_template")
+ elasticsearch_id = conf.get("elasticsearch", "log_id_template",
fallback=es_log_it_template_fallback)
+
+ # TODO: The elasticsearch specific stuff here is probably inappropriate -
provider is bleeding into core
Review Comment:
Oh. Absolutely -we have still a few remnants of it and I hope when I go with
#44511 we can get rid of all those remnants.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
