potiuk commented on code in PR #44755:
URL: https://github.com/apache/airflow/pull/44755#discussion_r1875584286
##########
airflow/cli/cli_config.py:
##########
@@ -865,7 +865,7 @@ def string_lower_type(val):
# kubernetes cleanup-pods
ARG_NAMESPACE = Arg(
("--namespace",),
- default=conf.get("kubernetes_executor", "namespace"),
+ default=conf.get("kubernetes_executor", "namespace", fallback="default"),
Review Comment:
I think you can't remove those defaults. This is a bit chicken-egg problem.
At this moment (when parsing args) we do not have providers configuration
loaded YET. Loading provider confguration takes few 100 milliseconds and that
visibly eats into any cli command if we are loading providers when we just want
to figure out what are the command line parameters. So here, fallback
**should** remain hard-coded even if this is technically duplication.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
