tirkarthi commented on code in PR #45183:
URL: https://github.com/apache/airflow/pull/45183#discussion_r1896903158
##########
airflow/ui/src/pages/TaskInstance/Logs.tsx:
##########
@@ -110,6 +136,26 @@ export const Logs = () => {
<Code overflow="auto" py={3} textWrap={wrap ? "pre" : "nowrap"}>
<VStack alignItems="flex-start">{data.parsedLogs}</VStack>
</Code>
+ <Dialog.Root
+ onOpenChange={onOpenChange}
+ open={fullscreen}
+ scrollBehavior="inside"
+ size="full"
+ >
+ <Dialog.Content backdrop>
+ <Dialog.Header>
+ <Heading size="xl">Log</Heading>
+ </Dialog.Header>
+
+ <Dialog.CloseTrigger />
+
+ <Dialog.Body>
Review Comment:
Thanks, I suppose the entire content from can become a component like
`<LogComponent>` and then show `FullScreen` based on the present inside the
dialog or not like below. Are there any other ways to do this idiomatic in
react without a separate component?
```html
<Box>
<LogComponent showFullScreenButton />
<Dialog>
<LogComponent />
</Dialog>
</Box>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
