pierrejeambrun commented on code in PR #45183:
URL: https://github.com/apache/airflow/pull/45183#discussion_r1897423205
##########
airflow/ui/src/pages/TaskInstance/Logs.tsx:
##########
@@ -110,6 +136,26 @@ export const Logs = () => {
<Code overflow="auto" py={3} textWrap={wrap ? "pre" : "nowrap"}>
<VStack alignItems="flex-start">{data.parsedLogs}</VStack>
</Code>
+ <Dialog.Root
+ onOpenChange={onOpenChange}
+ open={fullscreen}
+ scrollBehavior="inside"
+ size="full"
+ >
+ <Dialog.Content backdrop>
+ <Dialog.Header>
+ <Heading size="xl">Log</Heading>
+ </Dialog.Header>
+
+ <Dialog.CloseTrigger />
+
+ <Dialog.Body>
Review Comment:
+1 for keeping the header. It's taking really few real estate in the page
and allowing to navigate without having to close and then open again the full
screen mode.
That's also consistant with how we build the graph,grid, etc... views.
(there's a header). Also maybe the Task id too would be helpful. (for the grid
graph etc... we have the dag_id). I can easily imagine someone losing track of
what logs he is looking at after a while reading in the full screen page. Let's
imagine we have multiple opened tabs like this at the same time, it's difficult
to navigate and remember about.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
