pierrejeambrun commented on code in PR #45183:
URL: https://github.com/apache/airflow/pull/45183#discussion_r1905726336
##########
airflow/ui/src/pages/TaskInstance/Logs.tsx:
##########
@@ -77,26 +84,47 @@ export const Logs = () => {
return (
<Box p={2}>
- <HStack justifyContent="space-between" mb={2}>
- {taskInstance === undefined || tryNumber === undefined ||
taskInstance.try_number <= 1 ? (
- <div />
- ) : (
- <TaskTrySelect
- onSelectTryNumber={onSelectTryNumber}
- selectedTryNumber={tryNumber}
- taskInstance={taskInstance}
- />
- )}
- <Button aria-label={wrap ? "Unwrap" : "Wrap"} bg="bg.panel"
onClick={toggleWrap} variant="outline">
- {wrap ? "Unwrap" : "Wrap"}
- </Button>
- </HStack>
+ <TaskLogHeader
+ onSelectTryNumber={onSelectTryNumber}
+ taskInstance={taskInstance}
+ toggleFullscreen={toggleFullscreen}
+ toggleWrap={toggleWrap}
+ tryNumber={tryNumber}
+ wrap={wrap}
+ />
<ErrorAlert error={error ?? logError} />
<Skeleton />
<ProgressBar size="xs" visibility={isLoading || isLoadingLogs ?
"visible" : "hidden"} />
<Code overflow="auto" py={3} textWrap={wrap ? "pre" : "nowrap"}>
<VStack alignItems="flex-start">{data.parsedLogs}</VStack>
</Code>
+ <Dialog.Root onOpenChange={onOpenChange} open={fullscreen}
scrollBehavior="inside" size="full">
+ <Dialog.Content backdrop>
+ <Dialog.Header>
+ <Heading size="xl">{taskId}</Heading>
+ <TaskLogHeader
+ isFullscreen
+ onSelectTryNumber={onSelectTryNumber}
+ taskInstance={taskInstance}
+ toggleFullscreen={toggleFullscreen}
+ toggleWrap={toggleWrap}
+ tryNumber={tryNumber}
+ wrap={wrap}
+ />
+ </Dialog.Header>
+
+ <Dialog.CloseTrigger />
+
+ <Dialog.Body>
+ <ErrorAlert error={error ?? logError} />
+ <Skeleton />
+ <ProgressBar size="xs" visibility={isLoading || isLoadingLogs ?
"visible" : "hidden"} />
+ <Code overflow="auto" py={3} textWrap={wrap ? "pre" : "nowrap"}>
+ <VStack alignItems="flex-start">{data.parsedLogs}</VStack>
+ </Code>
Review Comment:
This should be factorized, maybe inside a `Logs/LogContent.tsx` Component.
Because for now its a few lines repeated, and it will grow bigger and bigger
with log parsing, colors, and collapsible log groups. We will need it at some
point.
Maybe even bring in the skeleton and progress bar. That I can easily imagine
it being reused outside of that page. When people do need the Log content
codebock somewhere else, we can extract it to the shared `components` folder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
