Re: [PR] Add full screen view for logs [airflow]

Tue, 24 Dec 2024 10:11:06 -0800 


tirkarthi commented on code in PR #45183:
URL: https://github.com/apache/airflow/pull/45183#discussion_r1896905325


##########
airflow/ui/src/pages/TaskInstance/Logs.tsx:
##########
@@ -110,6 +136,26 @@ export const Logs = () => {
       <Code overflow="auto" py={3} textWrap={wrap ? "pre" : "nowrap"}>
         <VStack alignItems="flex-start">{data.parsedLogs}</VStack>
       </Code>
+      <Dialog.Root
+        onOpenChange={onOpenChange}
+        open={fullscreen}
+        scrollBehavior="inside"
+        size="full"
+      >
+        <Dialog.Content backdrop>
+          <Dialog.Header>
+            <Heading size="xl">Log</Heading>
+          </Dialog.Header>
+
+          <Dialog.CloseTrigger />
+
+          <Dialog.Body>

Review Comment:
   I tried copy pasting code to try this out. IMO it still takes up some space 
with tries, I would prefer selecting the log and then clicking on the 
fullscreen to utilise the screen space fully.
   
   Full screen with task tries and wrap
   
   
![image](https://github.com/user-attachments/assets/6095753d-fa80-42cd-932d-c209bf303820)
   
   Fullscreen without dialog header
   
   
![image](https://github.com/user-attachments/assets/11214b5c-0db1-4f2d-8a75-8e38e6450d70)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to