pierrejeambrun commented on code in PR #47826:
URL: https://github.com/apache/airflow/pull/47826#discussion_r2000540973
##########
airflow/ui/src/components/DataTable/TableList.tsx:
##########
@@ -50,15 +55,18 @@ export const TableList = <TData,>({ renderSubComponent,
table }: DataTableProps<
return (
<Table.ColumnHeader colSpan={colSpan} key={id}
whiteSpace="nowrap">
{isPlaceholder ? undefined : (
- <Button
- aria-label="sort"
- disabled={!canSort}
- onClick={column.getToggleSortingHandler()}
- variant="plain"
- >
- {text}
- {rightIcon}
- </Button>
+ <>
+ <Button
+ aria-label="sort"
+ disabled={!canSort}
+ onClick={column.getToggleSortingHandler()}
+ variant="plain"
+ >
+ {text}
+ {rightIcon}
+ </Button>
+ {filterButton}
Review Comment:
Nit: I don't think this is a good place for the button. This is mixed up in
the middle of headers and I personally had a hard time finding it.
Maybe that should always be at the start of the column header. (First item
on the left).
Or maybe outside of the table header completely. 🤔 (that would also solve
your concern)
> One minor issue is because it's on the first element of the table if you
hide that the menu closes, so you'd have to reopen it (it will rightly move to
the new first element though).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
