bbovenzi commented on code in PR #47826:
URL: https://github.com/apache/airflow/pull/47826#discussion_r2001622427
##########
airflow/ui/src/components/DataTable/TableList.tsx:
##########
@@ -50,15 +55,18 @@ export const TableList = <TData,>({ renderSubComponent,
table }: DataTableProps<
return (
<Table.ColumnHeader colSpan={colSpan} key={id}
whiteSpace="nowrap">
{isPlaceholder ? undefined : (
- <Button
- aria-label="sort"
- disabled={!canSort}
- onClick={column.getToggleSortingHandler()}
- variant="plain"
- >
- {text}
- {rightIcon}
- </Button>
+ <>
+ <Button
+ aria-label="sort"
+ disabled={!canSort}
+ onClick={column.getToggleSortingHandler()}
+ variant="plain"
+ >
+ {text}
+ {rightIcon}
+ </Button>
+ {filterButton}
Review Comment:
I think its ok to put it in a row above the table header. We should have
filtering options in that row anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
