Re: [PR] Adds support for hiding columns in datatable [airflow]

Thu, 20 Mar 2025 10:51:33 -0700 


pierrejeambrun commented on code in PR #47826:
URL: https://github.com/apache/airflow/pull/47826#discussion_r2006166906


##########
airflow/ui/src/components/DataTable/DataTable.tsx:
##########
@@ -125,6 +133,10 @@ export const DataTable = <TData,>({
     <>
       <ProgressBar size="xs" visibility={Boolean(isFetching) && 
!Boolean(isLoading) ? "visible" : "hidden"} />
       <Toaster />
+      <HStack>
+        <Spacer display="flow" />
+        {allowFiltering ? <FilterMenuButton table={table} /> : undefined}
+      </HStack>

Review Comment:
   The button should be hidden if there is no rows, or if the display mode is 
'card':
   ![Screenshot 2025-03-20 at 18 50 
26](https://github.com/user-attachments/assets/8d114b1a-8372-440d-91ee-200cabadfcb2)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to