aritra24 commented on code in PR #47826:
URL: https://github.com/apache/airflow/pull/47826#discussion_r2000702744
##########
airflow/ui/src/components/DataTable/TableList.tsx:
##########
@@ -50,15 +55,18 @@ export const TableList = <TData,>({ renderSubComponent,
table }: DataTableProps<
return (
<Table.ColumnHeader colSpan={colSpan} key={id}
whiteSpace="nowrap">
{isPlaceholder ? undefined : (
- <Button
- aria-label="sort"
- disabled={!canSort}
- onClick={column.getToggleSortingHandler()}
- variant="plain"
- >
- {text}
- {rightIcon}
- </Button>
+ <>
+ <Button
+ aria-label="sort"
+ disabled={!canSort}
+ onClick={column.getToggleSortingHandler()}
+ variant="plain"
+ >
+ {text}
+ {rightIcon}
+ </Button>
+ {filterButton}
Review Comment:
Yeah, I wasn't too happy about it there either. One issue with moving it out
of the header was it'd take up an entire column's worth of space of its own, if
we had a table title I could see it being on the opposing end of the title, but
that isn't there here, I also considered making it its own thing above the
headers but that didn't look right either... I would like someone with better
design sense than me to recommend a location for it 🥲
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
