ephraimbuddy commented on code in PR #56422:
URL: https://github.com/apache/airflow/pull/56422#discussion_r2434943034
##########
airflow-core/src/airflow/models/serialized_dag.py:
##########
@@ -412,7 +412,7 @@ def write_dag(
serialized_dag_hash = session.scalars(
select(cls.dag_hash).where(cls.dag_id ==
dag.dag_id).order_by(cls.created_at.desc())
).first()
- dag_version = DagVersion.get_latest_version(dag.dag_id,
session=session)
+ dag_version = DagVersion.get_latest_version(dag.dag_id,
session=session, load_dag_model=True)
Review Comment:
We have to use a different arg. `load_dag_model` is used in other places
where we don't want to load serialized dag. With with you have, we will now
load serialized dag whenever load_dag_model is set whereas what we want is to
only load dag model and never serialized dag. So introduce another arg for
loading only the serialized dag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
