SavingFrame commented on code in PR #57828:
URL: https://github.com/apache/airflow/pull/57828#discussion_r2494009285
##########
airflow-core/src/airflow/api_fastapi/common/parameters.py:
##########
@@ -251,11 +251,6 @@ def to_orm(self, select: Select) -> Select:
if column is None:
column = getattr(self.model, lstriped_orderby)
- # MySQL does not support `nullslast`, and True/False ordering
depends on the
- # database implementation.
- nullscheck = case((column.isnot(None), 0), else_=1)
-
- columns.append(nullscheck)
Review Comment:
> This feels like it will break MySQL, and instead of removing this it
should be placed behind and "if ismysql:" style check.
Basically current solution will use default database behavior for each
database.
- Postgres:
- ASC - nulls in the end
- DESC - nulls in the start
- Mysql:
- ASC - nulls in the start
- DESC - nulls in the end
Instead database will always prefer index(if it possible) instead of scan
table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
