pierrejeambrun commented on code in PR #57828:
URL: https://github.com/apache/airflow/pull/57828#discussion_r2498453008
##########
airflow-core/src/airflow/api_fastapi/common/parameters.py:
##########
@@ -251,11 +251,6 @@ def to_orm(self, select: Select) -> Select:
if column is None:
column = getattr(self.model, lstriped_orderby)
- # MySQL does not support `nullslast`, and True/False ordering
depends on the
- # database implementation.
- nullscheck = case((column.isnot(None), 0), else_=1)
-
- columns.append(nullscheck)
Review Comment:
Also this makes me think that anyway this piece of code need to go. Because
it will always prevent index usage of any column used for sorting. Basically
the 'order_by' column is configurable from the query, so we would have the same
problem with other available sorting columns.
Then we might need to add some other indexes to support performant other
sorting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
