SavingFrame commented on code in PR #57828:
URL: https://github.com/apache/airflow/pull/57828#discussion_r2509764297
##########
airflow-core/src/airflow/api_fastapi/common/parameters.py:
##########
@@ -251,11 +251,6 @@ def to_orm(self, select: Select) -> Select:
if column is None:
column = getattr(self.model, lstriped_orderby)
- # MySQL does not support `nullslast`, and True/False ordering
depends on the
- # database implementation.
- nullscheck = case((column.isnot(None), 0), else_=1)
-
- columns.append(nullscheck)
Review Comment:
This is pain to have such many indexes for ordering and will negatively
affect performance during writing. Honestly I agree with you, this feature is
good to have, but it has a huge impact on performance. I'd remove it at all and
then slowly add where we really need it and where we have small amount of
elements
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
