pierrejeambrun commented on code in PR #57828:
URL: https://github.com/apache/airflow/pull/57828#discussion_r2494469438
##########
airflow-core/src/airflow/api_fastapi/common/parameters.py:
##########
@@ -251,11 +251,6 @@ def to_orm(self, select: Select) -> Select:
if column is None:
column = getattr(self.model, lstriped_orderby)
- # MySQL does not support `nullslast`, and True/False ordering
depends on the
- # database implementation.
- nullscheck = case((column.isnot(None), 0), else_=1)
-
- columns.append(nullscheck)
Review Comment:
I tend to think that we should remove this piece of code, and default to the
database default sorting for nulls. This was a 'nice to have' improvement
because users usually don't care about nulls, but even that can be argued with.
So I think it's a lot of trouble for a very little added value.
At least this will make the endpoint 'usable' again from a performance point
of view. Then we can later on add this back, more carefully, depending on the
db used etc... there are multiple things to consider, and I don't think it's
worth the effort at this point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
