xBis7 commented on code in PR #59139:
URL: https://github.com/apache/airflow/pull/59139#discussion_r2597269358
##########
airflow-core/tests/unit/always/test_project_structure.py:
##########
Review Comment:
I guess this should fail, so it seems to be working.
##########
task-sdk/src/airflow/sdk/module_loading.py:
##########
@@ -14,70 +14,6 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-
from __future__ import annotations
-from collections.abc import Callable
-from importlib import import_module
-
-
-def import_string(dotted_path: str):
Review Comment:
`is_valid_dotpath` has been moved. What about `import_string` and
`qualname`? Are they removed entirely?
##########
devel-common/src/tests_common/test_utils/providers.py:
##########
@@ -22,7 +22,7 @@
def object_exists(path: str):
"""Return true if importable python object is there."""
- from airflow.utils.module_loading import import_string
+ from airflow_shared.module_loading import import_string
Review Comment:
All other shared imports in `devel-common` are following the format
`airflow._shared.*` or `airflow.sdk._shared.*`.
##########
shared/configuration/pyproject.toml:
##########
@@ -33,6 +33,7 @@ dependencies = [
[dependency-groups]
dev = [
"apache-airflow-devel-common",
+ "apache-airflow-shared-module-loading",
Review Comment:
Since they are both shared and we are using relative imports, is this needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
