amoghrajesh commented on code in PR #59139:
URL: https://github.com/apache/airflow/pull/59139#discussion_r2597349829
##########
airflow-core/src/airflow/jobs/triggerer_job_runner.py:
##########
@@ -38,6 +38,7 @@
from sqlalchemy import func, select
from structlog.contextvars import bind_contextvars as bind_log_contextvars
+from airflow._shared.module_loading import import_string
Review Comment:
Same comment as above
##########
airflow-core/src/airflow/dag_processing/bundles/manager.py:
##########
@@ -23,13 +23,13 @@
from pydantic import BaseModel, ValidationError
from sqlalchemy import delete, select
+from airflow._shared.module_loading import import_string
Review Comment:
We could use this but more realistically, sdk one is correct?
##########
airflow-core/docs/authoring-and-scheduling/serializers.rst:
##########
@@ -87,7 +87,7 @@ Registered
from typing import TYPE_CHECKING
- from airflow.utils.module_loading import qualname
+ from airflow._shared.module_loading import qualname
Review Comment:
As discussed previously here, lets do:
```suggestion
from airflow.sdk.module_loading import qualname
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
