pierrejeambrun commented on code in PR #59374: URL: https://github.com/apache/airflow/pull/59374#discussion_r2623901004
########## airflow-core/src/airflow/ui/tests/e2e/specs/dags-list.spec.ts: ########## @@ -0,0 +1,108 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { expect, test } from "@playwright/test"; +import { testConfig } from "playwright.config"; +import { DagsPage } from "tests/e2e/pages/DagsPage"; +import { LoginPage } from "tests/e2e/pages/LoginPage"; + +/** + * DAGS-001: Verify DAGs List Displays + * + * This test verifies that the DAGs list page displays correctly after login, + * including the presence of the DAGs table and at least one DAG entry. + */ + +test.describe("DAGs List Display", () => { + let loginPage: LoginPage; + let dagsPage: DagsPage; + + // Test configuration from centralized config + const testCredentials = testConfig.credentials; + + test.beforeEach(({ page }) => { + loginPage = new LoginPage(page); + dagsPage = new DagsPage(page); + }); + + test("should display DAGs list after successful login", async () => { + test.setTimeout(2 * 60 * 1000); // 2 minutes timeout Review Comment: Is there a way to set this for all 3 tests here. (maybe in the before each?) ``` test.beforeEach(async ({ page }, testInfo) => { // Extend timeout for all tests running this hook by 30 seconds. testInfo.setTimeout(2 * 60 * 1000); }); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
