amoghrajesh commented on code in PR #59883: URL: https://github.com/apache/airflow/pull/59883#discussion_r2652743386
########## task-sdk/src/airflow/sdk/listeners/listener.py: ########## @@ -0,0 +1,36 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +from functools import cache + +from airflow.plugins_manager import integrate_listener_plugins +from airflow.sdk._shared.listeners.listener import ListenerManager + + +@cache +def get_listener_manager() -> ListenerManager: + """Get singleton listener manager.""" + _listener_manager = ListenerManager() + # TODO: For the time being, task sdk will use airflow's plugin mechanism to discover listeners and load them. + # We need to work out a better way to do this in the future. + integrate_listener_plugins(_listener_manager) # type: ignore[arg-type] Review Comment: I don't love this. I can think of a way through entrypoints, wondering what others think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
